ramanathan1504 commented on PR #4156: URL: https://github.com/apache/logging-log4j2/pull/4156#issuecomment-4990785505
@vpelikh However, your new processor works so well that it actually caught a pre-existing violation in main! When building locally, the compile fails in log4j-jdbc because JdbcAppender is missing public setters: ``` [ERROR] .../log4j/jdbc/appender/JdbcAppender.java:[61,25] The field immediateFail does not have a public setter. [ERROR] .../log4j/jdbc/appender/JdbcAppender.java:[81,22] The field reconnectIntervalMillis does not have a public setter. ``` Could you please update `JdbcAppender.java` in this PR (either by adding the missing setters or suppressing the warning) so the CI builds successfully? Once the build is green, I'll happily approve and merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
