LuckysHorizon commented on PR #4183: URL: https://github.com/apache/logging-log4j2/pull/4183#issuecomment-5019256163
> @LuckysHorizon > > Thanks for opening this PR for #2791. I wanted to give you a heads-up on what's been happening in parallel: > > **Context:** There's already been work on this issue across multiple PRs: > > * PR [2791 Fix handling of `onMatch` and `onMismatch` attributes in the properties configuration format #3505](https://github.com/apache/logging-log4j2/pull/3505) (initial approach) – reviewed with pending comments > * PR [Fix handling of `onMatch` and `onMismatch` attributes in the properties configuration format #4116](https://github.com/apache/logging-log4j2/pull/4116) (my PR) – built on top of [2791 Fix handling of `onMatch` and `onMismatch` attributes in the properties configuration format #3505](https://github.com/apache/logging-log4j2/pull/3505)'s commits + additional patches to address gaps – currently under review by @vy with most comments resolved, just a few pending > > **Suggestion:** Since PR #4116 is nearly complete (most feedback addressed, just final touches needed), and it touches a lot of surface area (~60 files), I'd recommend we consolidate effort there rather than split review across multiple PRs. > > Would you be open to collaborating on clearing the last few comments on #4116? That way we avoid duplicate review work and get to the finish line faster. If you'd like to contribute, I can brief you on the pending feedback and we can tackle it together. > > Let me know your thoughts! Thanks for the context and for the heads-up! I wasn't aware that #4116 had already progressed this far. My intention with this PR was to provide a focused fix for the compatibility issue reported in #2791 and add a regression test to prevent it from recurring. I'm happy to avoid duplicating effort. If #4116 is the preferred direction and is close to merging, I'd be glad to help address the remaining review comments there instead. Feel free to point me to the outstanding feedback or any specific areas where I can help. Thanks again for letting me know! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
