ppkarwasz commented on PR #403:
URL: 
https://github.com/apache/logging-log4j-samples/pull/403#issuecomment-5077960709

   I pushed some manual changes on top of the Dependabot commit:
   
   - **Reverted the Spring Boot 4.1.0 and Spring Cloud 2025.1.2 bumps** back to 
3.5.7 and 2025.0.0. Spring Boot 4 requires code changes (removed 
`spring-boot-starter-aop`, Spring Framework 7 and Spring Security 7 API 
removals, JUnit 6), which will be delivered in a separate PR.
   - Managed `org.osgi.annotation.bundle` in the root POM, since 
`logging-parent` 12.x intentionally no longer manages annotation dependencies.
   - Added JSpecify (referenced by `log4j-api` 2.26.1) as a provided dependency 
to the WAR samples, so bnd can import the annotations package instead of 
reporting private references.
   - Imported `netty-bom` 4.1.135.Final in the Spring Cloud sample application, 
since `kubernetes-client` 7.8.0 requires a more recent Netty than the one 
managed by `spring-boot-dependencies` 3.5.7.
   - Grouped the root POM `dependencyManagement` entries into IDE-foldable 
regions.
   
   `./mvnw verify` passes for all modules with these changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to