vy commented on code in PR #4218: URL: https://github.com/apache/logging-log4j2/pull/4218#discussion_r3782056719
########## src/changelog/.2.x.x/fix_logger_context_admin_config_stream_leak.xml: ########## @@ -0,0 +1,8 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.org/xml/ns"; + xsi:schemaLocation="https://logging.apache.org/xml/ns https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="fixed"> + <issue id="4218" link="https://github.com/apache/logging-log4j2/pull/4218"/> + <description format="asciidoc">Close caller-owned configuration streams in JMX `LoggerContextAdmin.setConfigLocationUri` with try-with-resources (keep stream-backed `ConfigurationSource` for file watchers)</description> Review Comment: ```suggestion <description format="asciidoc"> Fix file descriptor leak in the JMX integration </description> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
