vpelikh commented on PR #4153: URL: https://github.com/apache/logging-log4j2/pull/4153#issuecomment-5341985960
Thanks for the review, @ramanathan1504! I’ve addressed both points: 1. @Required test that can actually fail — The previous testConfigurationWithTextNEG only asserted configuration.getFilter() is null, which would still pass if @Required were removed (since build() returns null anyway). I updated it to attach a ListStatusListener and assert the constraint-validation error is actually reported. If the @Required constraint on the text field is dropped, the ConstraintValidationException no longer fires and this test fails. 2. setMatchString has no test — Added testFilterBuilderWithDeprecatedSetMatchString, which exercises the deprecated alias and asserts the built filter carries the expected text. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
