tupelo-schneck commented on PR #4226:
URL: https://github.com/apache/logging-log4j2/pull/4226#issuecomment-5411817913
Thanks for reviewing both — consolidated as you asked.
#4227's change is now here as 79037d369, and I have closed #4227 pointing at
this PR. The description is rewritten to cover both fixes, and the two
changelog entries now both reference this one.
Briefly, on the second fix, since it arrived without its own discussion: a
direct write file was being named after the moment the appender started rather
than after the rollover period it covers, so a restart later in the period
opened a second file for a period meant to have one. Under a weekly schedule
with a `%d{yyyyMMdd}` pattern, a week of daily restarts leaves seven files
instead of one. Fixing it partly unwinds LOG4J2-3339 and changes direct write
file names for cron based appenders, so it is worth a look on its own terms —
the reasoning and the compatibility note are in the description.
`./mvnw verify` passes on the combined branch across all 41 modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
