FreeAndNil commented on code in PR #322:
URL: https://github.com/apache/logging-log4net/pull/322#discussion_r4072838478
##########
src/log4net/Repository/Hierarchy/XmlHierarchyConfigurator.cs:
##########
@@ -205,9 +208,24 @@ public void Configure(XmlElement? element)
}
}
+ ActivatePendingAppenders();
+
// Done reading config
}
+ /// <summary>
+ /// Activates the appenders parsed in this pass, in creation order.
+ /// </summary>
+ private void ActivatePendingAppenders()
+ {
+ _deferActivation = false;
+ foreach (IOptionHandler optionHandler in _pendingActivations)
+ {
+ optionHandler.ActivateOptions();
+ }
Review Comment:
Fixed in 93ed24f
- ActivatePendingAppenders catches the failure, logs it, and discards the
appender
- discarding detaches it from the root, every logger and every container,
then closes it
- children are unwired before the close, or a container would take down an
appender a logger still holds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
