MaxFreedomPollard commented on PR #4304: URL: https://github.com/apache/logging-log4j2/pull/4304#issuecomment-5792053283
Applied all five suggestions in `440ddd4`. The only change is layout: spotless wraps the password assertion over several lines. With the fix, all six `SmtpAppenderTest` tests pass. The new test fails if `.setSmtpPassword(smtpPassword)` is removed (`requestPasswordAuthentication` returns null), if `.setSmtpProtocol(smtpProtocol)` is removed (the manager names differ: `smtps` against the default `smtp`), and without the fix (`NullPointerException: name`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
