ramanathan1504 commented on code in PR #4353: URL: https://github.com/apache/logging-log4j2/pull/4353#discussion_r4199502233
########## src/changelog/.2.x.x/4348_log4j1_converter_preserve_lookups.xml: ########## @@ -0,0 +1,11 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.org/xml/ns"; + xsi:schemaLocation="https://logging.apache.org/xml/ns https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="fixed"> + <issue id="4348" link="https://github.com/apache/logging-log4j2/issues/4348"/> + <issue id="4353" link="https://github.com/apache/logging-log4j2/pull/4353"/> + <description format="asciidoc"> + Keep Log4j 1 variable indirection when converting a properties configuration, instead of capturing host system properties. Review Comment: ```suggestion Fix `Log4j1ConfigurationConverter` to write `${sys:name}` lookups instead of resolved system property values. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
