ramanathan1504 commented on code in PR #4358: URL: https://github.com/apache/logging-log4j2/pull/4358#discussion_r4202925198
########## src/changelog/.2.x.x/4347_auth_encoding.xml: ########## @@ -0,0 +1,11 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.org/xml/ns"; + xsi:schemaLocation="https://logging.apache.org/xml/ns https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="fixed"> + <issue id="4347" link="https://github.com/apache/logging-log4j2/issues/4347"/> + <issue id="4358" link="https://github.com/apache/logging-log4j2/pull/4358"/> + <description format="asciidoc"> + Honor the legacy `logging.auth.encoding` property when configuring HTTP Basic Authentication and default to UTF-8 when no encoding property is configured. Review Comment: ```suggestion Honor `logging.auth.encoding` and default to UTF-8 in HTTP Basic Authentication. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
