ramanathan1504 commented on code in PR #4433:
URL: https://github.com/apache/logging-log4j2/pull/4433#discussion_r4390355988


##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java:
##########
@@ -201,6 +201,19 @@ public B asBuilder() {
         }
     }
 
+    /**
+     * Constructor that sets the name, level and additive values.
+     * @deprecated - For comapatibilty with 2.x.
+     *
+     * @param name The Logger name.
+     * @param level The Level.
+     * @param additive true if the Logger is additive, false otherwise.
+     */
+    @Deprecated
+    public LoggerConfig(final String name, final Level level, final boolean 
additive) {

Review Comment:
   Spring Boot only builds a `LevelSetLoggerConfig` when the Log4j config has 
no `<Logger>` with that exact name. Otherwise it calls `setLevel` on the 
existing one.
   So `logging.level.root` or a name already in `log4j2.xml` never reaches this 
constructor. `logging.level.com.example.notinconfig=DEBUG` should show the NPE.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to