ramanathan1504 commented on code in PR #4408: URL: https://github.com/apache/logging-log4j2/pull/4408#discussion_r4421960219
########## src/site/antora/modules/ROOT/pages/jakarta.adoc: ########## @@ -139,7 +151,17 @@ If set to `true`, the `Log4jServletContainerInitializer` will be disabled, which | Default value | `false` |=== -If set to `true`, the `Log4jServletContextListener` will not register a `Log4jServletContextListener` to handle the web application shut down. +If set to `true`, the `Log4jServletContainerInitializer` will not register a `Log4jServletContextListener` to shut down Log4j when the web application stops. +Automatic initialization remains enabled. + +You must arrange for Log4j to shut down, for example by registering +`org.apache.logging.log4j.web.Log4jShutdownOnContextDestroyedListener` +as the first listener in `web.xml`. +Do not register `Log4jServletContextListener` when this parameter is `true`. + +If you only need logging during other listeners' `contextDestroyed()` callbacks, +leave this parameter at its default value and follow the +<<log4j-jakarta-web-installation,listener-ordering guidance>>. Review Comment: This points back to the same WARNING block. The paragraph above already covers what to do when the parameter is `true`. ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
