Shekharrajak commented on PR #4411: URL: https://github.com/apache/logging-log4j2/pull/4411#issuecomment-6546077356
@ramanathan1504 , I did not understand why this PR is closed. This PR have 22 files and most of the changes are because of unit tests added. I explicitly asked to review the unit tests added in this PR in [this thread](https://github.com/apache/logging-log4j2/issues/4331#issuecomment-6394092245) . Can you please help in checking the unit test for the expected behavior ? The implementation is having the reserved keywords https://github.com/apache/logging-log4j2/pull/4411#discussion_r4387262318 , https://github.com/apache/logging-log4j2/pull/4411#discussion_r4390874733 , https://github.com/apache/logging-log4j2/pull/4411#discussion_r4390878182 this method helps in checking the reserved keyword https://github.com/apache/logging-log4j2/pull/4411/changes#diff-7f94b554443dbac06fb9e97e59afdabfa52dfebe6f6d4a7b51ef3001616a771cR54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
