takabayashi commented on issue #27: Updating Dockerfile to use Python 3 URL: https://github.com/apache/incubator-marvin/pull/27#issuecomment-505257326 Guys, let's make the changes simple to avoid big changes. In this case, the request is to add support to python3. A simple parameter can solve the problem easily without having to create more files and different flows. The engine-generator task has one parameter called --python lets just use it to change the template of the Dockerfile, customizing the installation. By default, this parameter uses the default python instalation. In this solution, if we going basically uses the same version the user has, at the same time we give then the flexibility to change the version. What do you think? Em sex, 21 de jun de 2019 às 12:36, Wei Chen <[email protected]> escreveu: > When using SageMaker, we can choose from python and python3. > And the default python is python2, that's why I think it might get a bit > confusing. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-marvin/pull/27?email_source=notifications&email_token=ABCEIJKI4IZYKGQ4F4GJVZ3P3UUTDA5CNFSM4HX5M4VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYJMXZQ#issuecomment-504548326>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABCEIJMV5U6OAPGN72GJCG3P3UUTDANCNFSM4HX5M4VA> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
