Wei-1 commented on a change in pull request #32: BaseURL Configuration for
MarvinAI Notebook
URL: https://github.com/apache/incubator-marvin/pull/32#discussion_r322280512
##########
File path: python-toolbox/tests/management/test_notebook.py
##########
@@ -40,7 +40,7 @@ def test_notebook(system_mocked, sys_mocked):
spark_conf = '/opt/spark/conf'
system_mocked.return_value = 1
- notebook(ctx, port, enable_security, spark_conf, allow_root)
+ notebook(ctx, port, '/', enable_security, spark_conf, allow_root)
Review comment:
I think it is better to still create a variable called `base_url` instead of
directly put a `'/'` in the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
