cardosolucas commented on a change in pull request #53:
URL: https://github.com/apache/incubator-marvin/pull/53#discussion_r494525091
##########
File path: marvin-cli/marvin_cli/management/engine.py
##########
@@ -84,8 +89,8 @@ def import_project(file, dest):
extract_folder(file, dest)
@cli.command("engine-dryrun", help="Run engines in a standalone way.")
[email protected]('--host', '-h', prompt='gRPC host', help='gRPC Host Address',
default='localhost')
[email protected]('--port', '-p', prompt='gRPC port', help='gRPC Port',
default='50057')
[email protected]('--host', '-gh', help='gRPC Host Address', default='localhost')
Review comment:
Yes, I think. Sorry for this, probably a copy and paste mistake. But we
could change this since `engine-httpserver` uses `--host` as well, so
`--grpchost` can be the standard for daemon host.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
