[GitHub] [incubator-marvin] cardosolucas commented on a change in pull request #55: Some bug fixes and bash completion

[GitBox]

cardosolucas commented on a change in pull request #55:
URL: https://github.com/apache/incubator-marvin/pull/55#discussion_r506480454



##########
File path: marvin-cli/marvin_cli/management/test.py
##########
@@ -23,32 +23,32 @@ def cli():
     pass
 
 @cli.command('test', help='Run tests.')
-@click.option('--host', '-h', prompt='gRPC host', help='gRPC Host Address', 
default='localhost')
-@click.option('--port', '-p', prompt='gRPC port', help='gRPC Port', 
default='50057')
+@click.option('--grpchost', '-gh', prompt='gRPC host', help='gRPC Host 
Address', default='localhost')
+@click.option('--grpcport', '-gp', prompt='gRPC port', help='gRPC Port', 
default='50057')
 @click.option('--cov/--no-cov', default=True)
 @click.option('--no-capture', is_flag=True)
 @click.option('--pdb', is_flag=True)
 @click.argument('args', default='')
-def test(host, port, cov, no_capture, pdb, args):
+def test(grpchost, grpcport, cov, no_capture, pdb, args):
     rc = RemoteCalls(host, port)

Review comment:
       Done!

##########
File path: marvin-cli/marvin_cli/management/test.py
##########
@@ -23,32 +23,32 @@ def cli():
     pass
 
 @cli.command('test', help='Run tests.')
-@click.option('--host', '-h', prompt='gRPC host', help='gRPC Host Address', 
default='localhost')
-@click.option('--port', '-p', prompt='gRPC port', help='gRPC Port', 
default='50057')
+@click.option('--grpchost', '-gh', prompt='gRPC host', help='gRPC Host 
Address', default='localhost')
+@click.option('--grpcport', '-gp', prompt='gRPC port', help='gRPC Port', 
default='50057')
 @click.option('--cov/--no-cov', default=True)
 @click.option('--no-capture', is_flag=True)
 @click.option('--pdb', is_flag=True)
 @click.argument('args', default='')
-def test(host, port, cov, no_capture, pdb, args):
+def test(grpchost, grpcport, cov, no_capture, pdb, args):
     rc = RemoteCalls(host, port)
     rc.run_test(cov, no_capture, pdb, args)
 
 @cli.command('test-tox', help='Run tests using Tox environment.')
-@click.option('--host', '-h', prompt='gRPC host', help='gRPC Host Address', 
default='localhost')
-@click.option('--port', '-p', prompt='gRPC port', help='gRPC Port', 
default='50057')
+@click.option('--grpchost', '-gh', prompt='gRPC host', help='gRPC Host 
Address', default='localhost')
+@click.option('--grpcport', '-gp', prompt='gRPC port', help='gRPC Port', 
default='50057')
 @click.argument('args', default='--current-env')
-def tox(host, port, args):
+def tox(grpchost, grpcport, args):
     rc = RemoteCalls(host, port)

Review comment:
       Done!

##########
File path: marvin-cli/marvin_cli/management/test.py
##########
@@ -23,32 +23,32 @@ def cli():
     pass
 
 @cli.command('test', help='Run tests.')
-@click.option('--host', '-h', prompt='gRPC host', help='gRPC Host Address', 
default='localhost')
-@click.option('--port', '-p', prompt='gRPC port', help='gRPC Port', 
default='50057')
+@click.option('--grpchost', '-gh', prompt='gRPC host', help='gRPC Host 
Address', default='localhost')
+@click.option('--grpcport', '-gp', prompt='gRPC port', help='gRPC Port', 
default='50057')
 @click.option('--cov/--no-cov', default=True)
 @click.option('--no-capture', is_flag=True)
 @click.option('--pdb', is_flag=True)
 @click.argument('args', default='')
-def test(host, port, cov, no_capture, pdb, args):
+def test(grpchost, grpcport, cov, no_capture, pdb, args):
     rc = RemoteCalls(host, port)
     rc.run_test(cov, no_capture, pdb, args)
 
 @cli.command('test-tox', help='Run tests using Tox environment.')
-@click.option('--host', '-h', prompt='gRPC host', help='gRPC Host Address', 
default='localhost')
-@click.option('--port', '-p', prompt='gRPC port', help='gRPC Port', 
default='50057')
+@click.option('--grpchost', '-gh', prompt='gRPC host', help='gRPC Host 
Address', default='localhost')
+@click.option('--grpcport', '-gp', prompt='gRPC port', help='gRPC Port', 
default='50057')
 @click.argument('args', default='--current-env')
-def tox(host, port, args):
+def tox(grpchost, grpcport, args):
     rc = RemoteCalls(host, port)
     rc.run_tox(args)
 
 @cli.command('test-tdd', help='Watch for changes to run tests automatically.')
-@click.option('--host', '-h', prompt='gRPC host', help='gRPC Host Address', 
default='localhost')
-@click.option('--port', '-p', prompt='gRPC port', help='gRPC Port', 
default='50057')
+@click.option('--grpchost', '-gh', prompt='gRPC host', help='gRPC Host 
Address', default='localhost')
+@click.option('--grpcport', '-gp', prompt='gRPC port', help='gRPC Port', 
default='50057')
 @click.option('--cov/--no-cov', default=False)
 @click.option('--no-capture', is_flag=True)
 @click.option('--pdb', is_flag=True)
 @click.option('--partial', is_flag=True)
 @click.argument('args', default='')
-def tdd(host, port, cov, no_capture, pdb, partial, args):
+def tdd(grpchost, grpcport, cov, no_capture, pdb, partial, args):
     rc = RemoteCalls(host, port)

Review comment:
       Done!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org