[ 
https://issues.apache.org/jira/browse/MYNEWT-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363370#comment-16363370
 ] 

ASF subversion and git services commented on MYNEWT-858:
--------------------------------------------------------

Commit a32116745e99b048ad60d39d4373959546cc8d08 in mynewt-newt's branch 
refs/heads/master from [~ccollins476]
[ https://gitbox.apache.org/repos/asf?p=mynewt-newt.git;h=a321167 ]

MYNEWT-858 Collect all package lflags during link.

If you add the following to a test package:

```
pkg.lflags:
    - "-foo"
```

and then test the package with `newt test`, the flag does not get passed
to gcc during linking.

Newt currently only reads lflags from the following package types:
* target
* app
* bsp
* compiler

Now, all packages' lflags are collected and specified during linking.


> Test package lflags ignored by `newt test`
> ------------------------------------------
>
>                 Key: MYNEWT-858
>                 URL: https://issues.apache.org/jira/browse/MYNEWT-858
>             Project: Mynewt
>          Issue Type: Bug
>      Security Level: Public(Viewable by anyone) 
>          Components: Newt
>            Reporter: Christopher Collins
>            Assignee: Sterling Hughes
>            Priority: Major
>              Labels: Newt
>             Fix For: v1_4_0_rel
>
>
> If you add the following to a test package:
> {noformat}
> pkg.lflags:
>     - "-foo"
> {noformat}
> and then test the package with `newt test`, the flag does not get passed to 
> gcc during linking.
> Newt currently only reads lflags from the following package types:
> * target
> * app
> * bsp
> * compiler
> At the very least, the test package's lflags should be used when a unit test 
> is linked via {{newt test}}.  Alternatively, it may make more sense to gather 
> the lflags from all constituent packages during the link phase.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to