[ 
https://issues.apache.org/jira/browse/MYNEWT-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363404#comment-16363404
 ] 

ASF GitHub Bot commented on MYNEWT-881:
---------------------------------------

vrahane commented on issue #718: MYNEWT-881 SensorAPI: LIS2DH12 set thresh cb 
fix
URL: https://github.com/apache/mynewt-core/pull/718#issuecomment-365477855
 
 
   @rymanluk I have addressed the comments and I do agree with your comments, I 
was a bit confused about the unset API since there are different ways of taking 
care of things but what I have done in the above commits should be good enough 
considering we have to enable/disable specific interrupts in the sensors 
registers if all the interrupts are not disabled. Hence, hal_gpio_irq_release() 
can only be called if all the thresholds are not valid. Hope I am making sense. 
Please go through the PR once again. Thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SensorAPI: Add sensor_unset_thresh() API and LIS2DH12 set threshold cb fix
> --------------------------------------------------------------------------
>
>                 Key: MYNEWT-881
>                 URL: https://issues.apache.org/jira/browse/MYNEWT-881
>             Project: Mynewt
>          Issue Type: Improvement
>      Security Level: Public(Viewable by anyone) 
>          Components: Drivers, Sensor Framework
>    Affects Versions: v1_3_0_rel
>         Environment: ruuvitag-revb2
>            Reporter: Vipul Rahane
>            Assignee: Vipul Rahane
>            Priority: Major
>              Labels: core
>             Fix For: v1_4_0_rel
>
>
> There are two issues for calling the lis2dh12_sensor_set_trigger_thresh() :
> 1. gpio irq was not being released before doing a re-initialization
>  2. srec was malloced and calling the function multiple times would have 
> malloced additional memory without freeing it.
> Solution:
>  1. Release the gpio irq
>  2. Remove the malloc and add a ptr for the sensor in each type trait so that 
> a sensor read could be performed in the irq handler.
> Also, sensor_unset_thresh() API was added to unset thresholds 
> triggers/interrupts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to