kasjer commented on code in PR #3270: URL: https://github.com/apache/mynewt-core/pull/3270#discussion_r1700874070
########## hw/mcu/nordic/nrf_common/src/hal_flash.c: ########## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include <string.h> +#include <assert.h> +#include "nrf.h" +#include "nrf_hal.h" +#include <hal/hal_flash_int.h> +#include "nrfx_nvmc.h" + +#ifdef NRF51 +#define NRF_FLASH_SECTOR_SZ 1024 +#else +#define NRF_FLASH_SECTOR_SZ 4096 +#endif + +#define NRF_FLASH_SECTOR_CNT (NRF_MEMORY_FLASH_SIZE / NRF_FLASH_SECTOR_SZ) + +static int nrf_flash_read(const struct hal_flash *dev, uint32_t address, + void *dst, uint32_t num_bytes); +static int nrf_flash_write(const struct hal_flash *dev, uint32_t address, + const void *src, uint32_t num_bytes); +static int nrf_flash_erase_sector(const struct hal_flash *dev, + uint32_t sector_address); +static int nrf_flash_sector_info(const struct hal_flash *dev, int idx, + uint32_t *address, uint32_t *sz); Review Comment: with shorter function names second line is misaligned. Same for hal_qspi.c ########## hw/mcu/nordic/nrf_common/src/hal_flash.c: ########## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include <string.h> +#include <assert.h> +#include "nrf.h" +#include "nrf_hal.h" +#include <hal/hal_flash_int.h> +#include "nrfx_nvmc.h" Review Comment: Mixing `<>` with `""` looks inconsistent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
