github-advanced-security[bot] commented on code in PR #1846:
URL: https://github.com/apache/mynewt-nimble/pull/1846#discussion_r1712954939
##########
nimble/host/src/ble_l2cap.c:
##########
@@ -427,7 +429,10 @@
goto err;
}
+ // REVIEW: It would be nice not to pass conn to decrease number of
arguments, timer reschedule could be processed here. Actually it could be
hoisted to the caller as it already processes the return value and knows about
l2cap fragments existence. So just return ble_l2cap_rx_payload(chan, om,
out_rx_cb);
Review Comment:
## Commented-out code
This comment appears to contain commented-out code.
[Show more
details](https://github.com/apache/mynewt-nimble/security/code-scanning/130)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
