rymanluk commented on code in PR #1851:
URL: https://github.com/apache/mynewt-nimble/pull/1851#discussion_r1722193421
##########
nimble/host/include/host/ble_gap.h:
##########
@@ -1582,6 +1582,14 @@ struct ble_gap_ext_adv_params {
/** Advertising Set ID */
uint8_t sid;
+
+#if MYNEWT_VAL(BLE_EXT_ADV_V2)
Review Comment:
since below fields are OK to be `0` which means, `host has not preference` I
would skip `BLE_EXT_ADV_V2` .
Instead, host could choose to use V2 or V1 based on the Read Supported
Commands result.
@sjanc @andrzej-kaczmarek what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
