szymon-czapracki commented on code in PR #1836:
URL: https://github.com/apache/mynewt-nimble/pull/1836#discussion_r1727255372
##########
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c:
##########
@@ -477,8 +479,7 @@ ble_svc_audio_bass_modify_source(uint8_t *data, uint16_t
data_len, uint16_t conn
operation.modify_source.pa_interval = get_le16(&data[offset]);
offset += 2;
- operation.modify_source.num_subgroups = get_le16(&data[offset]);
- offset += 2;
+ operation.modify_source.num_subgroups = get_le16(&data[offset++]);
Review Comment:
It's moved below - this was a mistake. We have to move offset after reading
number of subroups (which size is 1 byte - but I'm sure u know that :) )
##########
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h:
##########
@@ -325,7 +325,11 @@ struct ble_svc_audio_bass_operation {
uint16_t num_subgroups;
/** BIS Synchronisation of subgroups */
+ M
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
