andrzej-kaczmarek commented on code in PR #1857:
URL: https://github.com/apache/mynewt-nimble/pull/1857#discussion_r1745504171
##########
nimble/controller/src/ble_ll_adv.c:
##########
@@ -2564,6 +2576,24 @@ ble_ll_adv_reschedule_periodic_event(struct
ble_ll_adv_sm *advsm)
ble_ll_adv_sync_schedule(advsm, false);
}
+static void
+ble_ll_adv_update_did_periodic(struct ble_ll_adv_sm *advsm)
Review Comment:
instead of duplicating code refactor old code to simply return new value
instead of updating struct, i.e.
static uint16_t ble_ll_adv_adi_change_did(uint16_t adi) {}
...
advsm->adv_adi = ble_ll_adv_adi_change_did(advsm->adv_adi)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
