kasjer commented on code in PR #3321: URL: https://github.com/apache/mynewt-core/pull/3321#discussion_r1808192989
########## hw/hal/include/hal/hal_os_tick.h: ########## @@ -49,6 +49,12 @@ void os_tick_init(uint32_t os_ticks_per_sec, int prio); */ void os_tick_idle(os_time_t n); +/** + * Calculate the OS tick parameters. + * + * @param os_ticks_per_sec The number of OS ticks per second + */ +void hal_os_tick_calc_params(uint32_t os_ticks_per_sec); Review Comment: It's not clear why this function is in this header. It it used only in da1469x code so maybe it should be part of da1469x code. ########## hw/hal/include/hal/hal_system.h: ########## @@ -95,6 +95,16 @@ const char *hal_reset_cause_str(void); */ void hal_system_clock_start(void); +/** + * Calibrate selected LP clock + */ +void hal_system_lpclk_calibrate(void); + +/** + * Notify about LP clock update + */ +void hal_system_lpclk_updated(void); + Review Comment: Same as for the previous comment. Function are implemented and used only for da1469x. ########## hw/mcu/dialog/da1469x/include/mcu/da1469x_clock.h: ########## @@ -73,52 +123,91 @@ void da1469x_clock_lp_xtal32k_enable(void); */ void da1469x_clock_lp_xtal32k_switch(void); +/** + * Disable RC32K + */ +void da1469x_clock_lp_rc32k_disable(void); + +/** + * Enable RC32K + */ +void da1469x_clock_lp_rc32k_enable(void); + +/** + * Switch lp_clk to RC32K + */ +void da1469x_clock_lp_rc32k_switch(void); + +/** + * Disable RCX + */ +void da1469x_clock_lp_rcx_disable(void); + /** * Enable RCX */ void da1469x_clock_lp_rcx_enable(void); /** * Switch lp_clk to RCX - * - * Caller shall ensure RCX is already settled. */ void da1469x_clock_lp_rcx_switch(void); /** - * Calibrate RCX + * Calibrate RC32M */ -void da1469x_clock_lp_rcx_calibrate(void); +void da1469x_clock_rc32m_calibrate(void); + +/** + * Calibrate XTAL32K + */ +void da1469x_clock_lp_xtal32k_calibrate(void); /** * Calibrate RC32K */ void da1469x_clock_lp_rc32k_calibrate(void); /** - * Calibrate RC32M + * Calibrate RCX */ -void da1469x_clock_lp_rc32m_calibrate(void); +void da1469x_clock_lp_rcx_calibrate(void); + +/** + * Get calibrated (measured) RC32M frequency + */ +uint32_t da1469x_clock_lp_rc32m_freq_get(void); + +/** + * Get calibrated XTAL32K frequency + */ +uint32_t da1469x_clock_lp_xtal32k_freq_get(void); + +/** + * Get calibrated RC32K frequency + */ +uint32_t da1469x_clock_lp_rc32k_freq_get(void); /** * Get calibrated (measured) RCX frequency */ uint32_t da1469x_clock_lp_rcx_freq_get(void); /** - * Get calibrated (measured) RC32K frequency + * Get seleted LP clock's frequency */ -uint32_t da1469x_clock_lp_rc32k_freq_get(void); +uint32_t da1469x_clock_lp_freq_get(void); /** - * Get calibrated (measured) RC32M frequency + * Calibrate selected LP clock */ -uint32_t da1469x_clock_lp_rc32m_freq_get(void); +void da1469x_clock_lp_calibrate(void); /** - * Disable RCX + * Initialize selected LP RC clock */ -void da1469x_clock_lp_rcx_disable(void); +void +da1469x_lpclk_rc_init(); Review Comment: ```c void da1469x_lpclk_rc_init(void); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
