vrahane commented on code in PR #3365:
URL: https://github.com/apache/mynewt-core/pull/3365#discussion_r1956984007
##########
sys/log/full/syscfg.yml:
##########
@@ -179,6 +179,18 @@ syscfg.defs:
the global index to be sequentially increasing for persisted logs.
value: 0
+ LOG_FCB_NUM_ABS_BMARKS:
Review Comment:
What about `LOG_FCB_BOOKMARKS` they cannot be changed ? If thats the case I
think its best to keep this one syscfg as an exception. Do you agree ? Even if
I change `LOG_FCB_SECTOR_BOOKMARKS` to `LOG_FCB_SECTOR_BMARKS`, it will not
fetch us anything since `LOG_FCB_BOOKMARKS` will remain the way it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
