kasjer commented on code in PR #3370:
URL: https://github.com/apache/mynewt-core/pull/3370#discussion_r1961856335
##########
hw/usb/tinyusb/msc_fat_view/pkg.yml:
##########
@@ -78,5 +78,5 @@ pkg.init.'(!BOOT_LOADER && TINYUSB_AUTO_START!=0)':
pkg.init.'!BOOT_LOADER && MSC_FAT_VIEW_COREDUMP_FILES':
msc_fat_view_coredump_pkg_init:
- - $after:msc_fat_view_pkg_init
Review Comment:
@apc067 you could also remove next line so there is only one **$before**
You could also add following lines if you want:
```yml
pkg.init.'(!BOOT_LOADER && TINYUSB_AUTO_START==0)':
msc_fat_view_pkg_init: MYNEWT_VAL(MSC_FAT_VIEW_SYSINIT_STAGE)
```
those would remove build error if TINYUSB_AUTO_START is 0.
This setting is intended to delay start of USB so application can do some
more before USB is detected, application can call `tinyusb_start()` manually if
for example BLE stack should be activate first.
If you are not confident with my suggestion just leave single **$before**
and I will add those additional lines later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
