vrahane commented on code in PR #3382:
URL: https://github.com/apache/mynewt-core/pull/3382#discussion_r1992163907
##########
fs/fcb/src/fcb.c:
##########
@@ -257,14 +286,21 @@ fcb_offset_last_n(struct fcb *fcb, uint8_t entries,
int
fcb_clear(struct fcb *fcb)
{
- int rc;
+ int rc = 0;
+
+ rc = os_mutex_pend(&fcb->f_mtx, OS_WAIT_FOREVER);
+ if (rc && rc != OS_NOT_STARTED) {
+ return FCB_ERR_ARGS;
+ }
Review Comment:
I do not think there is any issue with nested locking of a mutex, it uses
`t_lockcnt` from `os_task`. Maybe more instructions to lock it which is
minimal. So, it is either that or more code for nested locking variants, I
choose less code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
