szymon-czapracki commented on code in PR #2035:
URL: https://github.com/apache/mynewt-nimble/pull/2035#discussion_r2082022456
##########
apps/bttester/src/btp_gap.c:
##########
@@ -515,6 +515,10 @@ start_advertising(const void *cmd, uint16_t cmd_len,
#if MYNEWT_VAL(BLE_EXT_ADV)
adv_params.own_addr_type = own_addr_type;
+
+ if (sd_len != 0) {
Review Comment:
This will need to be further discussed, as there are situations where sd_len
is actually 0, but we don't want to set scannable to 0. TBD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
