johnyangk commented on a change in pull request #187: [NEMO-324] Distinguish
Beam's run and waitUntilFinish methods
URL: https://github.com/apache/incubator-nemo/pull/187#discussion_r249325599
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/NemoPipelineResult.java
##########
@@ -49,10 +60,12 @@ public State cancel() throws IOException {
@Override
public State waitUntilFinish(final Duration duration) {
- throw new UnsupportedOperationException();
- // TODO #208: NemoPipelineResult#waitUntilFinish hangs
- // Previous code that hangs the job:
- // return (State) super.waitUntilJobFinish(duration.getMillis(),
TimeUnit.MILLISECONDS);
+ try {
+ this.jobDone.await();
Review comment:
According to the comments in PipelineResult#waitUntilFinish(Duration
duration), we should time out and return the current state after the specified
time, rather than waiting for the job to finish.
(The NEXMark benchmark uses this feature to collect metrics periodically)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
