johnyangk commented on issue #190: [NEMO-328] Refactor IRDAG URL: https://github.com/apache/incubator-nemo/pull/190#issuecomment-457114559 Thanks for the comments. I've updated the code. @sanha I've modified IRDAG#insert to receive multiple IREdges so the #189 continues to function as intended. I've run NetworkTraceAnalysisITCase#testDataSkew and verified the DAG topology. @wonook I've addressed your comments except for IRDAG#unSafeDirectReshaping, because the loop-related passes require direct access to the underlying DAG. It'd be good to handle this issue with a separate PR ([JIRA](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-330)). There also remains around 15 instances of DAG<IRVertex, IREdge> outside of IRDAG, mostly in loop-related passes and 2 in Spark-related classes for building new IRDAGs from RDD applications. Other than those instances, I've changed the type to IRDAG for consistency.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
