jeongyooneo commented on a change in pull request #191: [NEMO-332] Refactor RunTimePass URL: https://github.com/apache/incubator-nemo/pull/191#discussion_r252126465
########## File path: common/src/main/java/org/apache/nemo/common/ir/edge/executionproperty/PartitionSetProperty.java ########## @@ -18,19 +18,21 @@ */ package org.apache.nemo.common.ir.edge.executionproperty; -import org.apache.nemo.common.DataSkewMetricFactory; +import org.apache.nemo.common.KeyRange; import org.apache.nemo.common.ir.executionproperty.EdgeExecutionProperty; +import java.util.ArrayList; + /** - * DataSkewMetric ExecutionProperty. + * Number of partitions. Review comment: Could you elaborate on where this 'number of partitions' info used? Maybe mentioning some use cases(ex. skew handling) would be helpful. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
