johnyangk commented on a change in pull request #191: [NEMO-332] Refactor RunTimePass URL: https://github.com/apache/incubator-nemo/pull/191#discussion_r252905381
########## File path: common/src/main/java/org/apache/nemo/common/ir/vertex/system/MessageAggregatorVertex.java ########## @@ -16,28 +16,26 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.nemo.common; +package org.apache.nemo.common.ir.vertex.system; Review comment: I've explicitly added the `SystemIRVertex` abstract class to make it clearer that Stream/MessageBarrier/MessageAggregate vertices are provided by Nemo and allowed to be inserted into an IRDAG to optimize execution. (hence the "system" vertices) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
