johnyangk commented on a change in pull request #196: [NEMO-253] Refactor
getInternal(Main/Additional)OutputMap in TaskExecutor
URL: https://github.com/apache/incubator-nemo/pull/196#discussion_r260592043
##########
File path:
runtime/executor/src/test/java/org/apache/nemo/runtime/executor/task/TaskExecutorTest.java
##########
@@ -188,6 +189,24 @@ public void close() throws IOException {
assertTrue(checkEqualElements(elements,
runtimeEdgeToOutputData.get(taskOutEdge.getId())));
}
+ /**
+ * Test invalid parameter failure.
+ */
+ @Test()
+ public void testInvalidInputData() throws Exception {
+ try{
+ // Execute the task.
+ final TaskExecutor taskExecutor = getTaskExecutor(null, null);
+ taskExecutor.execute();
+
+ // Check the output.
Review comment:
Maybe change to:
// This should not be reached
Since we expect `taskExecutor.execute()` to throw `NullPointerException`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
