johnyangk commented on a change in pull request #201: [NEMO-358] Cloning a
vertex should also inherit the vertex ID
URL: https://github.com/apache/incubator-nemo/pull/201#discussion_r266319648
##########
File path: common/src/main/java/org/apache/nemo/common/ir/IdManager.java
##########
@@ -34,13 +40,42 @@ private IdManager() {
private static AtomicInteger edgeId = new AtomicInteger(1);
private static volatile boolean isDriver = false;
+ // Vertex ID Map to be used upon cloning in loop vertices.
+ private static final Map<Vertex, Queue<String>> VERTEX_ID_MAP = new
HashMap<>();
Review comment:
Move the changes in this file (IdManager.java) to LoopExtractionPass?
saveVertexId() seems to be used only there.
If saveVertexId() (and thus copying vertex IDs when cloning) is meant to be
generally used across all IRVertex subclasses, then I think the method should
be invoked in the constructor of the IRVertex class so that all its subclasses
inherit the behavior.
IRVertex class hierarchy:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
