johnyangk commented on issue #201: [NEMO-358] Recycling vertex ids while cloning a vertex URL: https://github.com/apache/incubator-nemo/pull/201#issuecomment-474216270 Thanks, LGTM. Note for future references: Only the **LoopExtractionPass** recycles LoopVertex ids with this PR. ID recycling is not implemented for any other cases. saveVertexId() (and thus id recycling) is only used once in LoopExtractionPass. Directly invoking IRVertex#getClone() or IRVertex#constructor(IRVertex that) continues to produce a new vertex id, even for LoopVertex.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
