wonook commented on a change in pull request #203: [NEMO-360] Implementing an
'XGBoostPolicy'
URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r267301446
##########
File path: pom.xml
##########
@@ -319,6 +319,9 @@ under the License.
<exclude>**/*.json</exclude>
<exclude>**/.editorconfig</exclude>
<exclude>**/config.gypi</exclude>
+ <!-- ML -->
+ <exclude>**/*.txt</exclude>
+ <exclude>venv/**</exclude>
Review comment:
As it's popular and common to use virtual environments (venv) with python,
I've added the folder for the exclusion of the relevant files. Do you think it
would make more sense to leave it as the responsibilities to the users using
venv to deal with it on their own?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
