wynot12 commented on a change in pull request #203: [NEMO-360] Implementing an 
'XGBoostPolicy'
URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r268667832
 
 

 ##########
 File path: 
common/src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/IgnoreSchedulingTempDataReceiverProperty.java
 ##########
 @@ -32,13 +32,13 @@
 public final class IgnoreSchedulingTempDataReceiverProperty extends 
VertexExecutionProperty<Boolean> {
 
   private static final IgnoreSchedulingTempDataReceiverProperty 
IGNORE_SCHEDULING_TEMP_DATA_RECEIVER_PROPERTY =
-    new IgnoreSchedulingTempDataReceiverProperty();
+    new IgnoreSchedulingTempDataReceiverProperty(true);
 
   /**
    * Constructor.
    */
-  private IgnoreSchedulingTempDataReceiverProperty() {
-    super(true);
+  private IgnoreSchedulingTempDataReceiverProperty(final Boolean value) {
+    super(value);
 
 Review comment:
   Why did you change it?
   I can't find any usage with value `false`.
   
   Moreover, it's out of scope of the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to