wynot12 commented on a change in pull request #215: [NEMO-373] Optimize with 
DAG Patterns
URL: https://github.com/apache/incubator-nemo/pull/215#discussion_r278994235
 
 

 ##########
 File path: 
compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/OptimizerUtils.java
 ##########
 @@ -36,28 +46,72 @@ private OptimizerUtils() {
   }
 
   /**
-   * Restore the formatted string into a pair of vertex/edge id and the 
execution property.
+   * Restore the formatted string into a pair of vertex/edge list and the 
execution property.
    *
    * @param string the formatted string.
-   * @return a pair of vertex/edge id and the execution property key index.
+   * @param dag the IR DAG to observe.
+   * @return a pair of vertex/edge list and the execution property key index.
    */
-  public static Pair<String, Integer> stringToIdAndEPKeyIndex(final String 
string) {
-    // Formatted into 9 digits: 0:vertex/edge 1-5:ID 5-9:EP Index.
+  public static Pair<List<Object>, Integer> stringToObjAndEPKeyIndex(final 
String string, final IRDAG dag) {
 
 Review comment:
   How about to change it to 'Obj**s**AndEPKeyIndex'?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to