johnyangk commented on a change in pull request #219: [NEMO-351] Empowering
Nemo with fast I/O using Apache Crail
URL: https://github.com/apache/incubator-nemo/pull/219#discussion_r292249269
##########
File path: conf/src/main/java/org/apache/nemo/conf/JobConf.java
##########
@@ -76,6 +76,22 @@
public final class GlusterVolumeDirectory implements Name<String> {
}
+ /**
+ * Directory points the CrailFileStore volume used to store files in remote
fashion.
+ * The directory has to be already created to give it as an option. (else
exception is thrown)
+ */
+ @NamedParameter(doc = "Directory points the CrailFS volume", short_name =
"crail_dir", default_value = "")
+ public final class CrailVolumeDirectory implements Name<String> {
+ }
+
+ /**
+ * RemoteFileStore option specification. Two choices are available:
GlusterFileStore or CrailFileStore.
+ * Default is the former one.
+ */
+ @NamedParameter(doc = "Option for RemoteFileStore", short_name =
"remote_option", default_value = "Gluster")
+ public final class RemoteFileStoreOpt implements Name<String> {
Review comment:
Please remove this parameter. I think only the DataStoreProperty on the IR
DAG should determine which store to use.
I noticed the CrailFileStore property you added.
https://github.com/apache/incubator-nemo/pull/219/files#diff-aa9a871d8e9c9075327f21350eab71d1R53
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
