hy00nc commented on a change in pull request #219: [NEMO-351] Empowering Nemo with fast I/O using Apache Crail URL: https://github.com/apache/incubator-nemo/pull/219#discussion_r296558238
########## File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/stores/RemoteFileStore.java ########## @@ -21,8 +21,9 @@ import org.apache.reef.tang.annotations.DefaultImplementation; /** - * Interface for remote block stores (e.g., GlusterFS, ...). + * Interface for remote block stores (e.g., GlusterFS, CrailFS...). */ + @DefaultImplementation(GlusterFileStore.class) Review comment: Actually `RemoteFileStore` is constructed by default in every job, and using Crail as the default would cause every job to fail when there is no CrailFileSystem detected on the nodes that run the job. So maybe `GlusterFileStore` can be the default? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
