bgchun commented on a change in pull request #223: [NEMO-388] Off-heap memory
management (reuse ByteBuffer)
URL: https://github.com/apache/incubator-nemo/pull/223#discussion_r307957842
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/stores/SerializedMemoryStore.java
##########
@@ -75,6 +79,9 @@ public void writeBlock(final Block block) throws
BlockWriteException {
*/
@Override
public boolean deleteBlock(final String blockId) {
+ for (Block block: getBlockMap().values()) {
+ block.release();
Review comment:
@hy00nc It'd be good to include tests that cover correct behavior of
off-heap memory management. Having tests helps you consider various cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
