hy00nc commented on issue #223: [NEMO-388] Off-heap memory management (reuse ByteBuffer) URL: https://github.com/apache/incubator-nemo/pull/223#issuecomment-516789458 So after addressing the comments, we now have two issues left to consider: 1) Whether it is worth including the code for random access of data using UNSAFE in MemoryChunk (which is not used except for tests in the project so far). 2) How to reuse (this is more focused on how *clean* the codes would be) the MemoryChunks that are used by other classes rather than SerializedMemoryBlock (i.e., NonSerializedMemoryBlock, FileBlock), since the current PR only includes reusing the MemoryChunk that belongs to SerializedMemoryBlock. Any suggestions/ideas would help a lot 👍
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
