taegeonum commented on a change in pull request #227: [NEMO-398] ExecutorRepresenter interface and DefaultExecutorRepresenter URL: https://github.com/apache/incubator-nemo/pull/227#discussion_r311562038
########## File path: runtime/master/src/main/java/org/apache/nemo/runtime/master/resource/ExecutorRepresenter.java ########## @@ -18,248 +18,95 @@ */ package org.apache.nemo.runtime.master.resource; -import com.fasterxml.jackson.databind.ObjectMapper; -import com.fasterxml.jackson.databind.node.ObjectNode; -import com.google.protobuf.ByteString; -import org.apache.commons.lang3.SerializationUtils; -import org.apache.nemo.common.ir.vertex.executionproperty.ResourceSlotProperty; -import org.apache.nemo.runtime.common.RuntimeIdManager; import org.apache.nemo.runtime.common.comm.ControlMessage; -import org.apache.nemo.runtime.common.message.MessageEnvironment; -import org.apache.nemo.runtime.common.message.MessageSender; import org.apache.nemo.runtime.common.plan.Task; -import org.apache.reef.driver.context.ActiveContext; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; -import javax.annotation.concurrent.NotThreadSafe; -import java.util.HashMap; -import java.util.HashSet; -import java.util.Map; import java.util.Set; -import java.util.concurrent.ExecutorService; -import java.util.stream.Collectors; -import java.util.stream.Stream; /** - * (WARNING) This class is not thread-safe, and thus should only be accessed through ExecutorRegistry. - * <p> - * Contains information/state regarding an executor. + * Interface for DefaultExecutorRepresenter and LambdaExecutorRepresenter. Review comment: This interface doesn't have to be for the two specific implementation. Please remove this comment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
