DifferentSC commented on a change in pull request #236: [NEMO-397] Separation
of JVM heap region and off-heap memory region
URL: https://github.com/apache/incubator-nemo/pull/236#discussion_r317033833
##########
File path: client/src/main/java/org/apache/nemo/client/JobLauncher.java
##########
@@ -441,7 +446,8 @@ private static Configuration getDeployModeConf(final
Configuration jobConf) thro
.build();
case "yarn":
return YarnClientConfiguration.CONF
- .set(YarnClientConfiguration.JVM_HEAP_SLACK,
injector.getNamedInstance(JobConf.JVMHeapSlack.class))
+ .set(YarnClientConfiguration.JVM_HEAP_SLACK,
injector.getNamedInstance(JobConf.JVMHeapSlack.class)
+ + injector.getNamedInstance(JobConf.MaxOffheapRatio.class))
Review comment:
Could you add the detailed comments on why the `JVM_HEAP_SLACK` should be
the sum of `JVMHeapSlack + MaxOffheapRatio`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
