wynot12 commented on a change in pull request #224: [NEMO-375] Clean up of
remnants of #211
URL: https://github.com/apache/incubator-nemo/pull/224#discussion_r327434806
##########
File path:
runtime/master/src/main/java/org/apache/nemo/runtime/master/metric/MetricStore.java
##########
@@ -278,6 +278,10 @@ public void saveOptimizationMetricsToDB(final String
address, final String jobId
final String dbId, final String
dbPasswd) {
final String[] syntax = {"SERIAL PRIMARY KEY"};
+ if (MetricUtils.metaDataLoaded()) {
+ MetricUtils.loadMetaData();
+ }
Review comment:
Why does it call `loadMetaData()` again when metadata is already loaded?
Is the previously loaded metadata stable?
Then please write a comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
