hy00nc commented on a change in pull request #243: [NEMO-422] SonarCloud issues URL: https://github.com/apache/incubator-nemo/pull/243#discussion_r334235900
########## File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/partition/SerializedPartition.java ########## @@ -59,7 +59,7 @@ @Nullable private final EncoderFactory.Encoder encoder; private final MemoryPoolAssigner memoryPoolAssigner; - private volatile List<MemoryChunk> dataList; + private List<MemoryChunk> dataList; Review comment: I suppose the reference does not change once it is assigned, either on commit() or construction, so it would be okay to non-volatilize it. @DifferentSC could you take a look too? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
