hy00nc commented on a change in pull request #273: [Nemo-429] SWPP TEAM15 Code
Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/273#discussion_r352974631
##########
File path: common/src/test/java/org/apache/nemo/common/DAGTest.java
##########
@@ -111,10 +111,10 @@ public void testNormalDAG() {
assertEquals(topologicalOrder.get(4).getValue(), 3);
assertEquals(dag.getRootVertices().size(), 2);
- assertEquals(dag.getParents("4").size(), 0);
+ assertEquals(0, dag.getParents("4").size());
Review comment:
For Team15, lines 116 and 117 were assigned. This fix may cause conflict for
other PRs, so could you leave this line untouched and fix line 116?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
