dkim94 commented on a change in pull request #278: [NEMO-429] SWPP TEAM16 Code 
Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/278#discussion_r353178700
 
 

 ##########
 File path: 
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/PipeManagerWorker.java
 ##########
 @@ -189,10 +189,10 @@ public void onInputContext(final ByteInputContext 
inputContext) throws InvalidPr
 
   private int getNumOfPipeToWait(final RuntimeEdge runtimeEdge) {
     final int dstParallelism = ((StageEdge) 
runtimeEdge).getDstIRVertex().getPropertyValue(ParallelismProperty.class)
-      .orElseThrow(() -> new IllegalStateException());
 
 Review comment:
   
https://sonarcloud.io/project/issues?fileUuids=AWkltI3qgtFwgfOLu2B4&id=org.apache.nemo%3Anemo-project&resolved=false&rules=squid%3AS1192%2Csquid%3AS1602%2Csquid%3AS1612
   
   Isn't this assigned to Team16?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to