DifferentSC commented on a change in pull request #262: [NEMO-429] SWPP TEAM8
Code Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/262#discussion_r352984023
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/source/BeamUnboundedSourceVertex.java
##########
@@ -123,7 +123,7 @@ public ObjectNode getPropertiesAsJsonNode() {
private static final class UnboundedSourceReadable<O, M extends
UnboundedSource.CheckpointMark>
implements Readable<Object> {
private final UnboundedSource<O, M> unboundedSource;
- private UnboundedSource.UnboundedReader<O> reader;
+ private UnboundedSource.UnboundedReader<O> reader; //NOSONAR
Review comment:
How about trying to define the generic type `O` as `O extends Serializable`?
Maybe this could fix the problem without commenting `//NOSONAR`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
